add icons for Gas, Power, Problem and Safety#6824
Closed
Mariusthvdb wants to merge 3 commits intohome-assistant:devfrom
Mariusthvdb:patch-1
Closed
add icons for Gas, Power, Problem and Safety#6824Mariusthvdb wants to merge 3 commits intohome-assistant:devfrom Mariusthvdb:patch-1
Mariusthvdb wants to merge 3 commits intohome-assistant:devfrom
Mariusthvdb:patch-1
Conversation
to allow for more fine-grained icon representation in the frontend.
Contributor
|
You also changed icons for “gas”. |
and corrected on/off icons (had them reversed)
Contributor
Author
didn't realize that, doing so by leaving them open... Now added alert biohazard for Gas, and reversed the on/off icons, which I had mixed up. |
Mariusthvdb
changed the title
bramkragten
reviewed
Sep 8, 2020
bramkragten
reviewed
Sep 8, 2020
```
return activated ? "hass:shield-check" : "hass:alert";
```
bramkragten
reviewed
Sep 29, 2020
Comment on lines
18
to
27
| case "gas": | ||
| return activated ? "hass:shield-check" : "hass:alert"; | ||
| case "power": | ||
| return activated ? "hass:power-off" : "hass:power"; | ||
| case "problem": | ||
| return activated ? "hass:check-circle" : "hass:alert-circle"; | ||
| case "safety": | ||
| return activated ? "hass:check-circle" : "hass:alert-circle"; | ||
| case "smoke": | ||
| return activated ? "hass:shield-check" : "hass:alert"; |
Member
There was a problem hiding this comment.
Suggested change
| case "gas": | |
| return activated ? "hass:shield-check" : "hass:alert"; | |
| case "power": | |
| return activated ? "hass:power-off" : "hass:power"; | |
| case "problem": | |
| return activated ? "hass:check-circle" : "hass:alert-circle"; | |
| case "safety": | |
| return activated ? "hass:check-circle" : "hass:alert-circle"; | |
| case "smoke": | |
| return activated ? "hass:shield-check" : "hass:alert"; | |
| case "power": | |
| return activated ? "hass:power-off" : "hass:power"; | |
| case "problem": | |
| return activated ? "hass:check-circle" : "hass:alert-circle"; | |
| case "safety": | |
| case "gas": | |
| case "smoke": | |
| return activated ? "hass:shield-check" : "hass:shield-alert"; |
Maybe fire-alert, but fire <> smoke?
Member
|
Please rebase this. |
Member
|
Any update on this? |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to allow for more fine-grained icon representation in the frontend.
Breaking change
Proposed change
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: